Add pg gem scope_all benchmark

[bmarkons]

Add pg suite with pg/postgres_scope_all benchmark.

[SamSaffron]

interestingly this can be done a fraction quicker if you avoid the #each_row and instead just use a double while loop iteration cause you can avoid a bunch of block transitions, its very very minor

[bmarkons]

@SamSaffron interesing note 🤔 I guess I should leave it as it is because I used iterating blocks in other scope_all benchmarks?

[SamSaffron]

yeah, it is a distraction, we should focus on getting that graph up on ruby bench, 3 lines on one benchmark

[SamSaffron]

@tgxworld can we merge this?

[tgxworld]

I'll prefer if we leave out the comment here. I believe the code is self explanatory.

[bmarkons]

@tgxworld yeah, It is. I was kind of in doubt because of defaults. I'll leave it out 👍

[tgxworld]

I prefer

conn = PG.connect(
  host: ENV.fetch("HOST", "localhost"),
  port: ..
)

The problem I have with flushing indentations is that changing anything in the first line forces us to re-indent all the lines polluting the commit history.

[bmarkons]

@tgxworld, fixed stuff you've suggested :)

[robin850]

As Noah mentioned in #79, there's a tiny schema inconsistency. Is that intentional that the admin, created_at and updated_at attributes aren't present in the PostgreSQL schema ? That would certainly be better to make sure that results can be compared apples to apples.

Looks great though ! 👍

[bmarkons]

Nice catch! I omitted created_at and updated_at by mistake.

Although none of scope_all benchmarks has admin field in schema. Admin field is present only in default_scope benchmarks.

I am not sure if scope_all benchmarks are about to be compared with default_scope benchmarks, these two are of different type. I had only in mind comparing scope_all (or default_scope) across AR, sequel or pg implementations.

[robin850]

Yeah, you're right Marko ! That looks great then !

[bmarkons]

@tgxworld
Do we want setup on RubyBench for pg and mysql gems same as for ActiveRecord and Sequel?
If yes, I think this one can be merged so I can continue with adding other benchmarks..

The next step would be to make and push docker image for pg suite.

[tgxworld]

@bmarkons Sorry for missing this. I guess we should enable this since the benchmarks have been added :)

[bmarkons]

Sure, I am writing driver for pg suite right now and Dockerfile.. :)