Add admin UI #227
Add admin UI #227
Conversation
|
|
||
| def set_repos | ||
| @repos = Repo.all | ||
| end |
There was a problem hiding this comment.
Missing blank line after this line :)
app/controllers/admin_controller.rb
Outdated
| @repos = Repo.all | ||
| end | ||
| def set_repo | ||
| @repo = Repo.find_by_name(params[:repo_name]) |
There was a problem hiding this comment.
Probably best to use find_by(name: ) here since find_by_* is deprecated in rails 5
|
Manual run is now possible through Admin UI 🚀 |
| @@ -13,6 +13,7 @@ bundler_args: --without development:production --deployment --retry=3 --jobs=3 | |||
| before_script: | |||
| - bundle exec rake db:create | |||
| - bundle exec rake db:migrate | |||
| - bundle exec rake assets:precompile &> /dev/null | |||
There was a problem hiding this comment.
Hmm this is alittle odd. Why do we need to precompile assets in our test env?
There was a problem hiding this comment.
According to teampoltergeist/poltergeist#677 (comment), a possible cause of the "Request failed to reach server" problem is that assets are being compiled on-demand, causing enough of a slowdown for PhantomJS to think the connection has failed. This turns off lazy asset compilation in the test environment and precompiles assets before testing on Travis.
I encountered this problem on Travis and solved it with assets precompilation.
Error occurred most probably because of introducing admin layout with its own asset group.
app/views/admin/repo.html.haml
Outdated
| - content_for(:page_header) do | ||
| = "#{@repo.name.capitalize} repo" | ||
|
|
||
|
|
There was a problem hiding this comment.
Style: Alot of blanks lines here :)
app/views/admin/home.html.haml
Outdated
| @@ -0,0 +1,2 @@ | |||
| - content_for(:page_header) do | |||
| = "Dashboard" | |||
There was a problem hiding this comment.
One good practice is to always use i18n when displaying text. You never know when we might need to support other languages in the future :)
There was a problem hiding this comment.
oh, sure.. forgot about i18n😕 I'll change this 👍
test/acceptance/admin_test.rb
Outdated
| repo = create(:repo) | ||
|
|
||
| visit admin_repo_path(repo.name) | ||
| page.must_have_content 'Run last' |
There was a problem hiding this comment.
Using i18n for text that are displayed will also allow you to avoid duplications in the test cases.
|
OK 👍 LGTM merge away and we can test it out in production :) Good work 👍 |
I used this bootstrap theme :
https://startbootstrap.com/template-overviews/sb-admin-2
I made new admin layout which is used by AdminController and reorganized assets to not have them mixed.
This PR goal is to make manual run possible through admin UI.