Skip to content

Commit

Permalink
Fix broken CI due to rake-compiler error on Ruby < 2.6
Browse files Browse the repository at this point in the history
The recently released rake-compiler 1.2.4 breaks compatibility with Ruby
2.5 and below. It is causing concurrent-ruby CI jobs to fail with errors
like this:

```
NoMethodError: undefined method `cleanpath' for "tmp/x86_64-linux/concurrent_ruby_ext/2.3.8":String
```

The rake-compiler regression has been reported here:

rake-compiler/rake-compiler#224

As a workaround, this PR updates the ruby-concurrent Gemfile to avoid
rake-compiler 1.2.4. This should fix the broken CI jobs.
  • Loading branch information
mattbrictson authored and eregon committed Aug 2, 2023
1 parent 3bfe39e commit bf966c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -12,7 +12,7 @@ gem 'concurrent-ruby-ext', Concurrent::VERSION, options.merge(platform: :mri)

group :development do
gem 'rake', '~> 13.0'
gem 'rake-compiler', '~> 1.0', '>= 1.0.7'
gem 'rake-compiler', '~> 1.0', '>= 1.0.7', '!= 1.2.4'
gem 'rake-compiler-dock', '~> 1.0'
gem 'pry', '~> 0.11', platforms: :mri
end
Expand Down

0 comments on commit bf966c0

Please sign in to comment.