Deprecated Concurrent::Atomic in lieu of Concurrent::AtomicReference. #277
Conversation
| # @!macro atomic_reference | ||
| # @deprecated Use Concurrent::AtomicReference instead. | ||
| class Concurrent::Atomic < Concurrent::AtomicReference | ||
| end |
There was a problem hiding this comment.
Do we need aliases for the different implementations? In my mind they are not included in the public API. Just assignment Atomic = AtomicReference might be better since it clearly says what is the main name and the alias will also correctly report full name AtomicReference.
jdantonio
force-pushed
the
namespacing
branch
2 times, most recently
from
72c199c
to
05788e9
Compare
|
The test that failed in the last run is one that is known to fail intermittently. See #271 |
| # @!macro atomic_reference | ||
| # @deprecated Use Concurrent::AtomicReference instead. | ||
| class Concurrent::Atomic < Concurrent::AtomicReference | ||
| end |
There was a problem hiding this comment.
I meant something like:
module Concurrent
Atomic = AtomicReference
endSo it is actually the same class, because having two classes with same behavior but not-identical may be causing problems in comparisons when both names are used.
There was a problem hiding this comment.
When I've tried to do that in the past yardoc wouldn't generate documentation for the 'alias' class. That's the main reason I did the subclass. What you say makes sense, though. I'll make the change and then figure out some way to get reasonable documentation in yardoc.
|
@jdantonio Are you able to restart the jobs on travis? It does not work for me :( |
|
I was able to restart it, but I had to log in to Travis in order to make the "restart" button visible. Interestingly, Travis says that the build has restarted, but I can't tell if it actually has. |
|
Thanks, I saw it but it was doing nothing :/ |
Deprecated Concurrent::Atomic in lieu of Concurrent::AtomicReference.
See #261