Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Fix JRubyCacheBackend::canUseUnsafeCHM on Android #4

Merged
merged 1 commit into from
Feb 15, 2015

Conversation

donv
Copy link
Contributor

@donv donv commented Feb 15, 2015

Avoid NullpointerException if t.getMessage() is null and detect "intrinsics" message in causing exception.
Both of these occur on Android.

…insics" message in causing exception.

Both of these occur on Android.
@jdantonio
Copy link
Member

Thank you!

@donv
Copy link
Contributor Author

donv commented Mar 5, 2015

Hi @jdantonio !

Could you release this change or make it possible to use master from GitHub with JRuby?

What is needed for using master directly in a Gemfile with JRuby is a precompiled JAR or a build step to compile the jar after checkout (using extconf, I think).

@jdantonio
Copy link
Member

@donv It's been almost a year since the last release so I think a new release is warranted. I'll check with the team to make sure everyone is OK with that.

@donv
Copy link
Contributor Author

donv commented Mar 5, 2015

Thanks!

@thedarkone
Copy link
Contributor

From me it's: 🚢 :shipit:.

@jdantonio
Copy link
Member

@donv I'm updating the project config (TravisCI, Coveralls, etc.) in #11. Once that's all working properly I'll create the next release. Probably tomorrow. Definitely this week.

@donv
Copy link
Contributor Author

donv commented Mar 11, 2015

@jdantonio Thanks! Appreciated 😄

@jdantonio
Copy link
Member

@donv I've released v0.3.5 with this patch. This is the first time I've pushed an update to this gem so please let me know ASAP of you have any issues!

@donv
Copy link
Contributor Author

donv commented Mar 11, 2015

I ran our tests with the new version, and I got an error. I will investigate, but it is hard to trace these errors, so it will take some time.

The visible error is

load error: fileutils -- java.lang.ArrayIndexOutOfBoundsException: length=256; index=1115438672

but that is likely a result of another error. I'll keep you informed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants