Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate git branch from master to main #516

Closed
marcoroth opened this issue Sep 11, 2023 · 8 comments
Closed

Migrate git branch from master to main #516

marcoroth opened this issue Sep 11, 2023 · 8 comments

Comments

@marcoroth
Copy link
Collaborator

marcoroth commented Sep 11, 2023

Most repositories have migrated to the new main git default. I was wondering if we should do the same here.

I was reluctant to just to do it because I don't know if it would affect deployments or the like, which is why I open this issue so we can discuss it.

@adarsh
Copy link
Collaborator

adarsh commented Sep 11, 2023 via email

@adarsh
Copy link
Collaborator

adarsh commented Sep 12, 2023

Seems like we may not be able to do this as of now, due to GH Pages:

https://github.com/orgs/community/discussions/23147

@marcoroth
Copy link
Collaborator Author

Oh interesting. I'm actually wondering if this is still the case. Quite some time has passed now 🤔

@adarsh
Copy link
Collaborator

adarsh commented Sep 12, 2023 via email

@Morozzzko
Copy link

Morozzzko commented Sep 12, 2023

image

Should be fine. That's a screenshot from my own Jekyll blog/repo. Visit Repo -> Settings -> Pages to see the config

@adarsh
Copy link
Collaborator

adarsh commented Sep 18, 2023

Ok I followed these tips and looks like it seems ok. I have not deleted master yet, out of caution. I did update GH Pages to deploy from main. 🤞🏾

LMK if it looks ok for others.

@marcoroth
Copy link
Collaborator Author

marcoroth commented Sep 18, 2023

I think this looks good. Seems like the site deployed successfully and the changes from #520 are up.

#520 was also the last pull request pointing to master.

We might be able to close this issue then.

@marcoroth
Copy link
Collaborator Author

marcoroth commented Oct 20, 2023

Closing this, as I think everything seems to be working well on main now! 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants