Fix dependencies for ruby 1.9.3 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epend on linecache19 nor columnize gems
|
Simpler implementation where ruby-debug-ide depends on the same version of ruby-debug-base19x under ruby 1.9.x |
denofevil
added a commit
that referenced
this pull request
Sep 3, 2014
Fix dependencies for ruby 1.9.3
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a candidate fix for #56.
If ruby 1.9.3 is detected, it will force the usage to 0.11.30.pre15 or later. I admit it isn't a perfect solution for those who would like only "stable" gems but I think that, pragmatically, it's an okay fix considering that:
Also, on a side note, I was tempted to move the dependency selection block in the begin block so that this whole if block doesn't get executed at all if the current ruby gem dependency requirements are met, but I stopped there, aiming for a minimal fix to facilitate a quick review...