support nested expose declarations
#47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -399,6 +417,12 @@ def value_for(attribute, options = {}) | |||
| elsif format_with.respond_to? :call | |||
| instance_exec(delegate_attribute(attribute), &format_with) | |||
| end | |||
|
|
|||
| elsif !nested_exposures.empty? | |||
There was a problem hiding this comment.
Minor: elsif nested_exposures.any?
|
This looks very good. You should update README and CHANGELOG, please (via |
|
Merged via 4284ee5, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #34
Here's a first attempt at supporting nested exposures.
Note: Previously, any supplied block would be assigned to
options[:proc]and called with the represented object and the runtime options. I used that fact as a delineation, so...This will break any implementations that supply Procs with no parameters.