Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options Errors and Alias :with and :using #51

Closed
wants to merge 4 commits into from
Closed

Options Errors and Alias :with and :using #51

wants to merge 4 commits into from

Conversation

aj0strow
Copy link
Contributor

Should fix #49.

Notes:

  • options are passed in two distinct places (in merge_options and in with_options) so a helper method valid_options covers both
  • had to change an existing spec to avoid using an unknown option
  • there's 6 rubocop offences but none of them are mine

@dblock
Copy link
Member

dblock commented Jan 13, 2014

Perfect. Needs a CHANGELOG and possibly a README update. Thanks.

@aj0strow
Copy link
Contributor Author

...

@dblock
Copy link
Member

dblock commented Jan 22, 2014

Sorry, forgot about this. Merging.

@dblock
Copy link
Member

dblock commented Jan 22, 2014

Merged via f335fe3.

@dblock dblock closed this Jan 22, 2014
@aj0strow aj0strow deleted the options-errors branch January 23, 2014 09:04
@aj0strow
Copy link
Contributor Author

no worries, thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

present :with versus expose :using inconsistency
2 participants
@aj0strow @dblock