Make default schemes undefined to match Swagger Spec #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There is already code to handle the scenario where the scheme is provided as a parameter.
wleeper
force-pushed
the
cr380_change_default_schemes
branch
from
bb4be10
to
996491f
Compare
|
+1 for an awesome commit message. |
|
👍 please update CHANGELOG |
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
…chemes Make default schemes undefined to match Swagger Spec → schemes are optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do, and where should I start?
This PR takes out the default value for schemes. This brings the generator in line with Swagger Spec 2.0 which indicates that schemes is an optional parameter and default behavior is to assume the same scheme as the scheme of the document.
How should this be manually tested?
Can be tested using the example (which did not work prior to this change) by running:
From the examples directory. This will start the example up on http://localhost:9292. Drop the
http://localhost:9292/swagger_docintohttp://petstore.swagger.ioand choose one of the methods to 'try'. It should successfully hit the back end.Any background context you want to provide?
Ran into this problem because we run our app in development on http only and the default value of
['https', 'http']failed to work. It also failed as noted to work with the example if started per the README.