Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds getting of a specified resource for Rake Tasks #501

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

LeFnord
Copy link
Member

@LeFnord LeFnord commented Sep 8, 2016

No description provided.

@grape-bot
Copy link

grape-bot commented Sep 8, 2016

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@LeFnord LeFnord force-pushed the master branch 2 times, most recently from 1262ad0 to 56fdf50 Compare September 8, 2016 23:09
@LeFnord LeFnord merged commit b4d25d5 into ruby-grape:master Sep 8, 2016
@dblock
Copy link
Member

dblock commented Sep 9, 2016

These things should really have tests. Check out https://github.com/digitalplaywright/mongoid-slug/blob/master/spec/tasks/mongoid_slug_rake_spec.rb for an example of how to test Rake tasks.

@LeFnord
Copy link
Member Author

LeFnord commented Sep 9, 2016

Yeap … I know 😉

LeFnord added a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants