Fixes the regexp used for parsing routes #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look like the broken tests are due to my PR but I can fix them if that is the case. |
In a character set, vertical bars `|` are treated as a proper character and not as an OR. They are not needed since character set applies the OR logic automatically.
|
I just rebased the PR. Can someone give me some feedback -- maybe @LeFnord ? |
|
thanks @senhalil … makes sense to me |
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
* Fix: incorrect regexp character set definition In a character set, vertical bars `|` are treated as a proper character and not as an OR. They are not needed since character set applies the OR logic automatically. * Update CHANGELOG.md Co-authored-by: peter scholz <pscholz.le@gmail.com>
Bhacaz
pushed a commit
to Bhacaz/grape-swagger
that referenced
this pull request
Aug 31, 2023
* Fix: incorrect regexp character set definition In a character set, vertical bars `|` are treated as a proper character and not as an OR. They are not needed since character set applies the OR logic automatically. * Update CHANGELOG.md Co-authored-by: peter scholz <pscholz.le@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called
add_swagger_documentationraises the following warning which is due to vertical bars|since they are parsed as literal characters and not as OR's in a character set[]definition.