CI, relax rules for "rack_edge" builds #1857
Conversation
test only a single job and allow failures
This comment has been minimized.
This comment has been minimized.
| @@ -2,6 +2,10 @@ language: ruby | |||
|
|
|||
| sudo: false | |||
|
|
|||
| # "gemfile" is required for "allow_failures" option, | |||
| # see https://docs.travis-ci.com/user/customizing-the-build/#matching-jobs-with-allow_failures | |||
| gemfile: | |||
There was a problem hiding this comment.
not sure if this is needed, as our .travis.yml already do not follow Travis requirement:
When matching jobs against the definitions given in allow_failures, all conditions in allow_failures must be met exactly, and all the keys in allow_failures element must exist in the top level of the build matrix (i.e., not in matrix.include).
or I'm missing something :)
There was a problem hiding this comment.
from the docs
and all the keys in allow_failures element must exist in the top level of the build matrix (i.e., not in matrix.include).
according to this information we should have rvm key on the top level of build matrix(?) but not in matrix.include
I used this example as basis(see the link to docs):
language: php
php:
- 5.6
- 7.0
env: # important!
matrix:
include:
- php: 7.0
env: KEY=VALUE
allow_failures:
- php: 7.0
env: KEY=VALUEWithout the top-level env, no job will be allowed to fail
There was a problem hiding this comment.
🤷♂️
@dblock sorry, I'm not sure that you mean. It's something like "I'm not sure what are you talking about" or "I don't know also". If this is the latter then ignore my comment above :)
There was a problem hiding this comment.
I meant I don't know also, trust whatever you do here
|
it might be worth considering whether we need a tracking issue for the breaking changes that are related to |
test only a single job and allow failures
ref #1856 (comment)