Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rack-test to 1.1.0 #1912

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Upgrade rack-test to 1.1.0 #1912

merged 1 commit into from
Oct 2, 2019

Conversation

dnesteryuk
Copy link
Member

As it was mentioned in #1658 empty arrays aren't ignored anymore, so specs should be updated.

Is a note in the changlelog required for this PR? It isn't a new feature, neither a bugfix 🤔

Closes #1656

@grape-bot
Copy link

grape-bot commented Oct 1, 2019

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1912](https://github.com/ruby-grape/grape/pull/1912): Upgrade rack-test to 1.1.0 - [@dnesteryuk](https://github.com/dnesteryuk).

Generated by 🚫 danger

@dblock dblock merged commit 3241eb7 into ruby-grape:master Oct 2, 2019
@dblock
Copy link
Member

dblock commented Oct 2, 2019

Merged. For the future it's OK to mention this in CHANGELOG, because it's real work, and we thank you for it, but not required.

@dnesteryuk dnesteryuk deleted the chore/upgrade-rack-test branch October 2, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to rack-test 0.7.0
3 participants