Run specs in random order #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
splattael
force-pushed
the
rspec-order-rand
branch
2 times, most recently
from
456f3d8
to
ee11b02
Compare
|
This is great, thank you. Do add yourself to CHANGELOG, this is important work. Squash, I'll merge. |
This commit also restores global state in couple of specs which caused flaky failures after enabling randomization.
splattael
force-pushed
the
rspec-order-rand
branch
from
ee11b02
to
137d474
Compare
splattael
changed the title
|
I also wanted to add a Thanks a lot @dblock 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables spec randomization by default. It also fixes a couple of failures discovered after enabling
--order=rand🤓