micro optimizations in allocating hashes and arrays #1915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few places where hashes could be mutated without side effects, they already work with copies of original hashes. So,
merge!
replaced some ofmerge
calls.Also,
Grape::Util::StackableValues
,Grape::Util::ReverseStackableValues
andGrape::Util::InheritableValues
got a base class which keeps common methodsto avoid duplication. Besides, that a
[]
andkeys
methods were optimized to allocate less arrays when it is possible.There is an additional benchmark which measures more complex scenario. Unfortunately, there isn't noticeable difference in performance between the master and this change. However, I also profiled the same endpoint as the benchmark has.
Before this change:
After this change:
Hash#merge
moved from second position to 5th.Grape::Util::StackableValues#[]
moved from 6th to 12th.