Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced array allocation #2014

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Reduced array allocation #2014

merged 1 commit into from
Mar 16, 2020

Conversation

ericproulx
Copy link
Contributor 

# Still based on our app

# current Grape master
allocated memory by class
-----------------------------------
  15834248  Array
  15730608  Hash
   6726012  String
   3079724  Regexp
    202016  MatchData

# next_version
allocated memory by class
-----------------------------------
  15730608  Hash
   6726012  String
   5870664  Array
   3079724  Regexp
    202016  MatchData

@grape-bot
Copy link

grape-bot commented Mar 16, 2020 •
edited
Loading

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Mar 16, 2020

Nice. Although I thought the old code was at least more interesting :)

@dblock dblock merged commit 20a6d3f into ruby-grape:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericproulx @grape-bot @dblock