Coerce an empty string to nil in case of the bool type #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnesteryuk
force-pushed
the
empty_string_and_bool
branch
2 times, most recently
from
7d83410
to
7404f1e
Compare
dblock
reviewed
May 3, 2020
| @@ -46,7 +46,7 @@ def call(val) | |||
|
|
|||
| attr_reader :type | |||
|
|
|||
| # This method maintaine logic which was defined by Virtus. For example, | |||
| # This method maintain logic which was defined by Virtus. For example, | |||
There was a problem hiding this comment.
If we fixing this, let's actually fix it with "This method maintains" :)
dblock
reviewed
May 3, 2020
| @@ -55,6 +55,12 @@ def reject?(val) | |||
| (val.is_a?(String) && type == Hash) || | |||
| (val.is_a?(Hash) && type == String) | |||
| end | |||
|
|
|||
| # Dry-Types treats an empty string as invalid. However, Grape community wants to have | |||
There was a problem hiding this comment.
I think we should explain why and link to the issue. How about: "However, Grape considers an empty string as absence of value and coerces it into nil."?
dblock
approved these changes
May 3, 2020
dnesteryuk
force-pushed
the
empty_string_and_bool
branch
3 times, most recently
from
6cd7fce
to
9f49439
Compare
dnesteryuk
force-pushed
the
empty_string_and_bool
branch
from
9f49439
to
fe172fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies a pending test in #2045