Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor route public_send to AttributeTranslator #2050

Merged
merged 1 commit into from
May 3, 2020
Merged

Refactor route public_send to AttributeTranslator #2050

merged 1 commit into from
May 3, 2020

Conversation

ericproulx
Copy link
Contributor

Hi,

I transformed route public send to actual methods in attribute_translator. Makes more sense than falling back on method_missing.

I also removed Any in router and use pure AttributeTranslator.

@grape-bot
Copy link

grape-bot commented May 3, 2020 •
edited
Loading

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@ericproulx
Transform translator public_send to actual methods in attribute_trans…
67f9417 
…lator.rb

Remove Any class in route and replace by pure AttributeTranslator
@ericproulx ericproulx force-pushed the attribute_translator_define_method branch from b24a582 to 67f9417 Compare May 3, 2020 15:43
@dblock
Copy link
Member

dblock commented May 3, 2020

:shipit:

@dblock dblock merged commit 2a4e2c2 into ruby-grape:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericproulx @grape-bot @dblock