Numeric is not a dry-types built-in type, fix coercion/validation #2271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.3+ if someone had a
Numeric
type parameter which worked in<1.3
- any valid non-blank value will silently fail validationThis happens because dry-types does not contain built-in type for
DryTypes::SomeScope::Numeric
andconst_get
by default searches ancestors, thus finding::Numeric
.Runtime error
undefined method `[]' for Numeric:Class
is treated as a validation error and leads to unexpected behavior.This PR adds mapping for Numeric that fixes it, also fallback to
const_get(.., false)
will make similar issues easier to debug.