Check for dry-types type existence and prevent unexpected top level const lookup #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vasfed
force-pushed
the
stricter_const_get
branch
3 times, most recently
from
2fa72ec
to
cd35a07
Compare
|
Solid! fix Rubocop and it's good with me. |
Vasfed
force-pushed
the
stricter_const_get
branch
from
cd35a07
to
c061898
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2271 - prevent silent validation fails for types not built-in in dry-types.
Instead of validation fail - check for
[]method presence in provided class at init time.