Fix response headers from lint #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactor
Replace `rack_response` to `error!`
call self.status once inside route
dblock
reviewed
Jan 21, 2024
Revert rack_response in inside_route with deprecation Add spec
|
dblock
approved these changes
Jan 21, 2024
UPGRADING.md
Outdated
| @@ -3,6 +3,9 @@ Upgrading Grape | |||
|
|
|||
| ### Upgrading to >= 2.1.0 | |||
|
|
|||
| #### Changes in rescue_from | |||
| `rack_response` has been deprecated and `error_response` has been removed. Use `error!` instead. | |||
There was a problem hiding this comment.
The rack_response method ... (just to make it a sentence)
Link to the PR here and a couple missing below.
See [#2414](https://github.com/ruby-grape/grape/pull/2414) for more information.
lib/grape/dsl/inside_route.rb
Outdated
| @@ -180,8 +180,9 @@ def error!(message, status = nil, additional_headers = nil) | |||
| # A Rack::Response object containing the specified message, status, and headers. | |||
| # | |||
| def rack_response(message, status = 200, headers = { Rack::CONTENT_TYPE => content_type }) | |||
| message = ERB::Util.html_escape(message) if headers[Rack::CONTENT_TYPE] == 'text/html' | |||
| Rack::Response.new([message], Rack::Utils.status_code(status), headers) | |||
| Grape.deprecator.warn('Use error! instead of rack_response') | |||
There was a problem hiding this comment.
I think this reads cleaner?
The rack_response method has been deprecated, use error! instead.
Change deprecation msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2411
Changes:
Rack::Utils.escape_htmlinstead ofERB::Util.escape_htmlrack_responsefrominside_routeif: ActiveSupport::VERSION::MAJOR >= ?in specs