Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response headers from lint #2414

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Fix response headers from lint #2414

merged 8 commits into from
Jan 22, 2024

Commits on Jan 21, 2024

  1. Only error! is public 

    Minor refactor
    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    5a61811 View commit details
    Browse the repository at this point in the history

  2. Remove rack_response from inside_route 

    Replace `rack_response` to `error!`
    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    50f355f View commit details
    Browse the repository at this point in the history

  3. error! is now private 

    call self.status once inside route
    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    d419b8a View commit details
    Browse the repository at this point in the history

  4. Fix rubocop

    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    be10a16 View commit details
    Browse the repository at this point in the history

  5. Add CHANGELOG.md

    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    5cc2265 View commit details
    Browse the repository at this point in the history

  6. Add UPGRADING.md entry 

    Revert rack_response in inside_route with deprecation
Add spec
    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    dc837a7 View commit details
    Browse the repository at this point in the history

  7. Fix escape_html

    @ericproulx
    ericproulx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    ac6c7a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Fix UPGRADING.md 

    Change deprecation msg
    @ericproulx
    ericproulx committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    aaa5982 View commit details
    Browse the repository at this point in the history