feat(interpolation): allow clients to use custom interpolation patterns #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new config: `I18n.config.interpolation_patterns`
Usage:
I18n.config.interpolation_patterns << /\{\{(\w+)\}\}/
I18n.interpolate("Hello, {{name}}", name: "tonytonyjan")
# => "Hello, tonytonyjan"
close ruby-i18n#319
tonytonyjan
force-pushed
the
feature/support-custom-interpolation-patterns
branch
from
26aacf4
to
196d144
Compare
radar
approved these changes
Oct 25, 2018
|
Thank you for the R @tonytonyjan, and also to @voldy for the initial PR in #319. I'll merge this into master now, and it will be released in 1.2.0 later on. |
Hamms
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Sep 22, 2020
Looks like `I18n::INTERPOLATION_PATTERNS` is being deprecated: ruby-i18n/i18n#439
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new config:
I18n.config.interpolation_patternsUsage:
This PR is an improved version of #319 with the following changes:
I18n::INTERPOLATION_PATTERNSto prevent from being changed by settingI18n.config.interpolation_patterns.