Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'uninitialized constant Net::LDAP::PDU::LdapPduError' error #317

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Fix 'uninitialized constant Net::LDAP::PDU::LdapPduError' error #317

merged 2 commits into from
Jul 6, 2020

Conversation

unagi
Copy link
Contributor

@unagi unagi commented Feb 14, 2019

This PR fixes 'uninitialized constant Net::LDAP::PDU::LdapPduError when unknown pdu-type occured.

satoryu
satoryu reviewed Feb 15, 2019
View reviewed changes
test/test_ldap_connection.rb Outdated Show resolved Hide resolved
lib/net/ldap/pdu.rb Outdated Show resolved Hide resolved
@unagi unagi force-pushed the bugfix-uninitialized_constant_pduerror branch from 3ef1c6e to bb34b7b Compare February 15, 2019 09:12
@benlangfeld
Copy link

Is there something blocking this from being merged?

@unagi
Copy link
Contributor Author

unagi commented Dec 6, 2019

@mtodd @satoryu ping

satoryu
satoryu approved these changes Dec 7, 2019
View reviewed changes
Copy link
Collaborator

@satoryu satoryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

But I don't have a permission to merge a PR of this repo.
Ping @mtodd or anyone who can do it.

HarlemSquirrel
HarlemSquirrel approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HarlemSquirrel HarlemSquirrel merged commit a7f3b25 into ruby-ldap:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoryu satoryu satoryu approved these changes

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@unagi @benlangfeld @satoryu @HarlemSquirrel