Reduce gem size #81
Merged
Reduce gem size #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metavida
approved these changes
Jan 2, 2022
There was a problem hiding this comment.
Makes sense! And thanks to the links to the relevant conversations so I could learn more about the deprecation/abandonment of the test_files config. I think I'll have time for a new point release over the next 2ish days.
If you have time one thing that still needs to be done before the new release is adding a line to the CHANGELOG. If you've got time to add to the CHANGELOG via this PR go for it! And if I get time first then I'll add to the CHANGELOG after merging this PR.
Thanks for your help improving this gem!
|
Done! :D
|
|
Just pushed version 0.16.0 to rubygems, which includes the changes from this PR! Thanks for helping make ruby-oembed better! |
|
Great! Thanks! Just released jekyll-embed-urls v0.4.4 to reflect this :)
https://rubygems.org/gems/jekyll-embed-urls
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing cleanup and noticed ruby-oembed gem was ~18MB, mostly because of
spec/cassettes/OEmbed_ProviderDiscovery.yml.