Escape all instances of " in """ delimited literals
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two bugs associated with `"""` delimited literals. First: such literals cannot end with a `"` (see `STRING_LITERAL_LONG_QUOTE` at https://www.w3.org/TR/turtle/#sec-grammar-grammar). Second: they cannot contain a sequence of three `"`. The prior `.gsub('"""', '\"""')` approach addresses this for cases where `"` appears in multiples of three, but fails for other cases (e.g. `""""`). Both bugs are fixed by escaping all `"` characters. An alternative addressing only the second bug might be: `.gsub('"""', '\""\"')`, which would ensure three quotes aren't ever left in a row. Closes #16.
no-reply
force-pushed
the
escape-quotes-in-multi-line
branch
from
6c36fd0
to
6c90d46
Compare
1 similar comment
|
Thanks Tom, there was a N3 serialization test that prompted the last change, and we may need a further tweak, but let’s go with this for now. |
|
Yeah, I'm pretty sure this is an improvement, but I did feel a little anxious that there might be a pile of edge cases. |
|
What do you think about a bugfix release with this? I could probably push one out later tonight or in the morning. |
|
It would be great if you would, I’m still in Washington after a JSON-LD WG meeting.
Been spending a bunch of time on n3 reasoning, too.
Gregg Kellogg
Sent from my iPhone
… On Feb 8, 2019, at 7:10 PM, Tom Johnson ***@***.***> wrote:
What do you think about a bugfix release with this?
I could probably push one out later tonight or in the morning.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs associated with
"""delimited literals.First: such literals cannot end with a
"(seeSTRING_LITERAL_LONG_QUOTEathttps://www.w3.org/TR/turtle/#sec-grammar-grammar).
Second: they cannot contain a sequence of three
". The prior.gsub('"""', '\"""')approach addresses this for cases where"appears in multiples ofthree, but fails for other cases (e.g.
"""").Both bugs are fixed by escaping all
"characters.An alternative addressing only the second bug might be:
.gsub('"""', '\""\"'),which would ensure three quotes aren't ever left in a row.
Closes #16.