Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAT timezone is parsed as -10:00 instead of +02:00 #25

Closed
wants to merge 1 commit into from
Closed

CAT timezone is parsed as -10:00 instead of +02:00 #25

wants to merge 1 commit into from

Conversation

geophilusd
Copy link

Ruby version 2.7.1
https://www.timeanddate.com/time/zones/cat
CAT Timezone must be parsed as +02:00. But it is getting parsed as -10:00

Actual:

> DateTime.parse("28 Sep 2020 12:00PM CAT").zone
=> "-10:00"

Expected:

> DateTime.parse("28 Sep 2020 12:00PM CAT").zone
=> "+02:00"

@geophilusd geophilusd changed the title CAT timezone is parsed as -10:00 instead of 02:00 CAT timezone is parsed as -10:00 instead of +02:00 Sep 28, 2020
@jeremyevans
Copy link
Contributor

The zonetab.list file is updated using the ext/date/update-abbr file. This skips existing entries by design, my guess would be for backwards compatibility. If you do remove the cat entry, you get 7200, so it does looks like the current offset for cat is not correct. @nobu, how do you think we should handle this? Should update-abbr compare the existing entries to the downloaded entries and report differences?

@nobu
Copy link
Member

nobu commented Sep 29, 2020

master...nobu:fix-update-abbr

Seems more 6 differences.
I don't know where these came from.

@jeremyevans
Copy link
Contributor

@nobu I reviewed your fix-update-abbr branch and I think we should merge it.

@nobu nobu mentioned this pull request Sep 30, 2020
Merged
@nobu nobu closed this in #26 Oct 1, 2020
@dmikurube dmikurube mentioned this pull request Mar 28, 2023
Open
dmikurube added a commit to embulk/embulk-util-rubytime that referenced this pull request Mar 28, 2023
@dmikurube
Disable tests for NDT, NST, CAT, SST, WAST, CCT, and EAST with CRuby
fdb69b4 
These zonetab IDs are imcompatible from Ruby 3.1. See:

* #64
* ruby/date#25
* ruby/date#26
* ruby/date@f08175e

The zonetab-based timezone parsing is "deprecated" in embulk-util-rubytime,
then we do not catch up with the update of Ruby.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geophilusd @jeremyevans @nobu