Continue the debuggee after detaching to Chrome

[ono-max]

Description

Currently, when a tab in Chrome DevTools is closed, the error occurs such as:

Before

DEBUGGER: Debugger can attach via TCP/IP (127.0.0.1:12345)
DEBUGGER: With Chrome browser, type the following URL in the address-bar:

   devtools://devtools/bundled/inspector.html?ws=127.0.0.1:12345

DEBUGGER: wait for debugger connection...
DEBUGGER: Connected.
# A tab is closed here
DEBUGGER: ReaderThreadError: Unsupported: 8
["/Users/s15236/workspace/debug/lib/debug/server_cdp.rb:61:in `extract_data'",
 "/Users/s15236/workspace/debug/lib/debug/server_cdp.rb:103:in `block in process'",
 "/Users/s15236/workspace/debug/lib/debug/server_cdp.rb:102:in `loop'",
 "/Users/s15236/workspace/debug/lib/debug/server_cdp.rb:102:in `process'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:69:in `block (3 levels) in activate'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:212:in `setup_interrupt'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:67:in `block (2 levels) in activate'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:359:in `block (2 levels) in accept'",
 "/Users/s15236/.rbenv/versions/2.6.8/lib/ruby/2.6.0/socket.rb:809:in `block (2 levels) in accept_loop'",
 "/Users/s15236/.rbenv/versions/2.6.8/lib/ruby/2.6.0/socket.rb:806:in `each'",
 "/Users/s15236/.rbenv/versions/2.6.8/lib/ruby/2.6.0/socket.rb:806:in `block in accept_loop'",
 "/Users/s15236/.rbenv/versions/2.6.8/lib/ruby/2.6.0/socket.rb:804:in `loop'",
 "/Users/s15236/.rbenv/versions/2.6.8/lib/ruby/2.6.0/socket.rb:804:in `accept_loop'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:357:in `block in accept'",
 "/Users/s15236/.rbenv/versions/2.6.8/lib/ruby/2.6.0/socket.rb:781:in `tcp_server_sockets'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:338:in `accept'",
 "/Users/s15236/workspace/debug/lib/debug/server.rb:48:in `block in activate'"]
DEBUGGER: Disconnected.

After

% exe/rdbg target2.rb --open=chrome --port 12345
DEBUGGER: Debugger can attach via TCP/IP (127.0.0.1:12345)
DEBUGGER: With Chrome browser, type the following URL in the address-bar:

   devtools://devtools/bundled/inspector.html?ws=127.0.0.1:12345

DEBUGGER: wait for debugger connection...
DEBUGGER: Connected.
# A tab is closed here
DEBUGGER: Disconnected.
DEBUGGER: wait for debugger connection...
DEBUGGER: Debugger can attach via TCP/IP (127.0.0.1:12345)
DEBUGGER: With Chrome browser, type the following URL in the address-bar:

   devtools://devtools/bundled/inspector.html?ws=127.0.0.1:12345

[ko1]

is it correct fix or ad-hoc fix?

[ono-max]

I think it's the correct fix. When the opcode is 8, it means a connection is closed.

FYI: https://datatracker.ietf.org/doc/html/rfc6455#section-5.2

[ko1]

Ok, another point is, exiting is correct or not. For example, it is one option to continue the debuggee.

[ono-max]

For example, it is one option to continue the debuggee.

I see. That may be useful.

In node.js, if a tab is closed, debuggee also quit. That's why I thought that finishing it is the correct way, though.

[ko1]

There are 3 options:

(1) exit the debuggee too
(2) continue the debuggee (same as gdb, remote rdbg, ...) -> detach
(3) back to the rdbg REPL (and wait for the input)

To debug a server process, (2) seems nice and after detaching, it is convenient if we can attach again.

[ono-max]

All right, let me implement it. Thanks 👍

[ono-max]

Updated.
@ko1 san, could you check this one?