Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not evaluate the method when "objectGroup" is "popover" #395

Closed
wants to merge 1 commit into from

Conversation

ono-max
Copy link
Collaborator

@ono-max ono-max commented Nov 17, 2021

Description

When the mouse cursor is placed over a piece of code, Chrome DevTools has the ability to display information about that object. CDP server for ruby debugger also supports it. However, there is a problem in some cases when the global variable is defined.

Problem

The global variable value always changes every time moving the cursor over bar method.

$foo = 1

def bar
  $foo += 1
end

bar

a = 1
b = 1
c = 1

Screen Shot 2021-11-17 at 19 33 33

To reproduce

After stopping at bar, hover the cursor over bar method several times.

How I fix it

If the hovered object is a method, it returns it without evaluation.

Screen Shot 2021-11-17 at 19 46 56

@ono-max ono-max changed the title Do not call the method when "objectGroup" is "popover" Do not evaluate the method when "objectGroup" is "popover" Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant