Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update several parts in CDP to support for the current change #421

Merged
merged 6 commits into from
Dec 7, 2021
Merged

Update several parts in CDP to support for the current change #421

merged 6 commits into from
Dec 7, 2021

Conversation

ono-max
Copy link
Collaborator

@ono-max ono-max commented Dec 5, 2021 •
edited
Loading

In this PR, I updated evaluation(related to #395) and properties parts to support for the current change.

Because current CDP is not consistent with DAP, there are some problems as follows:

  • DAP has some features, such as the ability to see detailed information about each property and to display special local variables, but CDP does not.
  • It's hard to maintain them.

@ono-max ono-max changed the title Update Evaluation part in CDP to support for the current change Update evaluation part in CDP to support for the current change Dec 5, 2021
@ono-max ono-max changed the title Update evaluation part in CDP to support for the current change Update evaluation parts in CDP to support for the current change Dec 5, 2021
@ono-max ono-max marked this pull request as ready for review December 6, 2021 00:52
@ono-max ono-max changed the title Update evaluation parts in CDP to support for the current change Update several parts in CDP to support for the current change Dec 6, 2021
@ko1 ko1 merged commit c9127cc into ruby:master Dec 7, 2021
@ono-max ono-max deleted the patch-15 branch December 7, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ono-max @ko1