Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include jars #27

Merged
merged 1 commit into from
Sep 30, 2021
Merged

include jars #27

merged 1 commit into from
Sep 30, 2021

Conversation

ahorek
Copy link

@ahorek ahorek commented Sep 30, 2021

digest/digest.jar should be included

olleolleolle
olleolleolle reviewed Sep 30, 2021
View reviewed changes
digest.gemspec Outdated Show resolved Hide resolved
@ahorek ahorek mentioned this pull request Sep 30, 2021
Closed
@knu
Copy link
Member

knu commented Sep 30, 2021

Thanks. It's sad the integration test passed because the digest library would be still available even if the jar were missing. 🥺

knu
knu requested changes Sep 30, 2021
View reviewed changes
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into one.

digest.gemspec Outdated Show resolved Hide resolved
@ahorek
Copy link
Author

ahorek commented Sep 30, 2021

It's sad the integration test passed because the digest library would be still available even if the jar were missing. 🥺

the library is available because it wasn't removed yet https://github.com/jruby/jruby/pull/6719/files

knu
knu approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@knu knu merged commit 7941af8 into ruby:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

@knu knu knu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahorek @knu @olleolleolle