url_encode: use CGI.escapeURIComponent #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too sure why I can add a conditional to handle this case. Let me know what you think @k0kubun. |
stdlib could be updated only if the Ruby version has it as a default gem instead of a non-gem standard library. CGI has been promoted to a default gem on 2.7 https://github.com/ruby/ruby/blob/v2_7_0/NEWS. Looks like 2.6 is not tested in the workflow (a separate problem), but it wouldn't work in Ruby 2.6 either. Given that Ruby 2.6 is EOL, I'm okay with requiring Ruby 2.7+ from the next ERB version. Can you do it in this PR to fix the CI? |
Ref: ruby/cgi#26 This native implementation is much faster and available in `cgi 0.3.3`.
byroot
force-pushed
the
cgi-escape-url
branch
from
83ea8c8
to
5b0ee7a
Compare
|
Done. |
k0kubun
approved these changes
Oct 25, 2022
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 25, 2022
(ruby/erb#23) Ref: ruby/cgi#26 This native implementation is much faster and available in `cgi 0.3.3`. ruby/erb@2d90e9b010
tenderlove
pushed a commit
to Shopify/ruby
that referenced
this pull request
Oct 27, 2022
(ruby/erb#23) Ref: ruby/cgi#26 This native implementation is much faster and available in `cgi 0.3.3`. ruby/erb@2d90e9b010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ruby/cgi#26
This native implementation is much faster and available in
cgi 0.3.3.