Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --with-libffi-source-dir feature and removed --enable-bundled-libffi option. #113

Merged
merged 19 commits into from
Oct 7, 2022

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 7, 2022

@hsbt hsbt changed the title Removed bundled libffi source feature. Add --with-libffi-source-dir feature and removed --enable-bundled-libffi option. Oct 7, 2022
@hsbt hsbt marked this pull request as ready for review October 7, 2022 05:12
@hsbt
Copy link
Member Author

hsbt commented Oct 7, 2022

Note: https://github.com/ruby/fiddle/actions/runs/3202406059/jobs/5231356410 is failing with memory leak. I'm not sure why it's happend.

@kou
Copy link
Member

kou commented Oct 7, 2022

Note: https://github.com/ruby/fiddle/actions/runs/3202406059/jobs/5231356410 is failing with memory leak. I'm not sure why it's happend.

We can omit the test for now.

@kou
Copy link
Member

kou commented Oct 7, 2022

Or we can just ignore the failure.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

.github/workflows/libffi.yml Outdated Show resolved Hide resolved
@hsbt hsbt merged commit 3f01392 into master Oct 7, 2022
@hsbt hsbt deleted the remove-extlibs branch October 7, 2022 06:18
@hsbt
Copy link
Member Author

hsbt commented Oct 7, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants