Add CI steps for --enable-bundled-libffi
#94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Sep 24, 2021
There was a problem hiding this comment.
It seems that SEGV isn't reproduced in CI. The failed job is just failed by extconf.rb: https://github.com/ruby/fiddle/pull/94/checks?check_run_id=3701968329
How about installing libffi by Homebrew when --enable-bundled-libffi is used in the job?
| @@ -12,6 +12,9 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| build_flags: | |||
| - "" | |||
| - " -- --enable-bundled-libffi" | |||
There was a problem hiding this comment.
Could you add this information to name?
We can't distinct this information from the current job list...
- macos-10.15 debug: https://github.com/ruby/fiddle/pull/94/checks?check_run_id=3701967650
- macos-10.15 debug: https://github.com/ruby/fiddle/pull/94/checks?check_run_id=3701968329
|
I removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hsbt reported an issue with
--enable-bundled-libffihere.I added a build that uses this flag, and that build is failing. I was able to reproduce @hsbt's issue. I think it's caused by libffi installed with homebrew and using the
--enable-bundled-libffiflag. My guess is that building the bundled libffi is failing, but the gem still compiles with the bundled ffi headers but links against the homebrew libffi.I'm not sure how to fix yet, but I wanted to send this PR to show the issue.