Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YARD gem and generator #217

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Add YARD gem and generator #217

merged 10 commits into from
Nov 2, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Oct 2, 2022

I developed a tool to generate RBS from YARD tags and applied it to YARD gem to generate RBS.

@ksss ksss requested a review from pocke as a code owner October 2, 2022 08:35
@pocke
Copy link
Member

pocke commented Oct 3, 2022

Could you commit the generator? Everyone else cannot modify the RBSs except you if the generator is unavailable in this repository.

@ksss
Copy link
Collaborator Author

ksss commented Oct 12, 2022

@pocke
I've committed the generator and regenerated!

@ksss ksss changed the title Add Yard gem Add YARD gem and generator Oct 13, 2022
@pocke pocke enabled auto-merge November 1, 2022 15:32
pocke
pocke requested changes Nov 1, 2022
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I merged main branch then the rbs is broken due to rack definition. Could you fix that?

@ksss
Copy link
Collaborator Author

ksss commented Nov 2, 2022

I fixed dependency for rack.
And also add to call check-untyped-call.rb on _scripts/test

pocke
pocke approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pocke pocke merged commit 9d61d7b into ruby:main Nov 2, 2022
@ksss ksss deleted the yard branch November 2, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @pocke