Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Change indexes.rdoc to indexes.md #812

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[DOC] Change indexes.rdoc to indexes.md #812

merged 3 commits into from
Dec 18, 2023

Conversation

BurdetteLamar
Copy link
Member

Per @st0012 request.

Comment on lines +90 to +93
{
"$": :show_source,
"@": :whereami,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wrap them in a code block

Suggested change
{
"$": :show_source,
"@": :whereami,
}
```rb
{
"$": :show_source,
"@": :whereami,
}
```

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triple backticks in list item did not work for me (displayed as code, backticks and all). Does non the currently indented code block work for you>?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spaces work. But all other markdown docs (mostly readme) uses backticks for code blocks, I want to standardise the format. If this doesn't work for you, I'll try update it later 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work for me; please update later.

doc/irb/indexes.md Outdated Show resolved Hide resolved
@ima1zumi
Copy link
Member

We should remove the rdoc syntax because it becomes difficult to read on GitHub.

For example, in the following example, I think it would be better to make these changes.
<tt> should be replaced with ` for easier readability in raw Markdown.

- <tt>-d</tt>: Set <tt>$DEBUG</tt> and {$VERBOSE}[rdoc-ref:IRB@Verbosity]  to +true+.
+ `-d`: Set `$DEBUG` and `$VERBOSE` to `true`.

convert rdoc to html

image

Markdown in GitHub

image

@BurdetteLamar
Copy link
Member Author

About this format change: this is at @st0012's request; for my part, I'm now aware of any trend in the Ruby world from .rdoc to .md.

@BurdetteLamar
Copy link
Member Author

We should remove the rdoc syntax because it becomes difficult to read on GitHub.

If this matters, it should be remarked upon in the Ruby doc guide, doc/contributing/documentation_guide.md.

@st0012
Copy link
Member

st0012 commented Dec 16, 2023

for my part, I'm now aware of any trend in the Ruby world from .rdoc to .md.

The entire contributing docs were rewritten with markdown in ruby/ruby#5899, with all the subsequent new pages being markdown too.

And even though it's not a rdoc to markdown rewrite, all new Ruby wiki pages are written in markdown as well.

Consider it's one of the most popular documentation format and has a rich set of supporting tools (e.g. VS Code extensions), I think in the long-term it'll be beneficial if we gradually migrate RDoc to markdown.

If this matters, it should be remarked upon in the Ruby doc guide, doc/contributing/documentation_guide.md.

I don't think I'm the right person, nor are we at the right time, to make this a universal guideline. Consider the amount of Ruby documentation written in RDoc, rewriting all of them at once would be basically impossible. But to gradually migrate them, it will require a consensus and a plan from the Ruby Core. And I don't think this is a priority anyway.

The reason I suggested this change in the last doc PR was because I think it's a good opportunity to do so now that we're thinking about IRB docs again. But that doesn't mean I feel such rewrite is a priority to the community.

@BurdetteLamar
Copy link
Member Author

@st0012, ready for your review.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@st0012 st0012 merged commit b1cd53c into ruby:master Dec 18, 2023
24 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Dec 20, 2023
(ruby/irb#812)

* Change indexes.rdoc to indexes.md

* Change indexes.rdoc to indexes.md

* Change indexes.rdoc to indexes.md

ruby/irb@b1cd53cbf7
@nurse nurse mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants