Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed integration test for user defined parameterizing rules #291

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Fix failed integration test for user defined parameterizing rules #291

merged 4 commits into from
Dec 12, 2023

Conversation

ydah
Copy link
Collaborator

@ydah ydah commented Dec 11, 2023

Follow up: #289

@ydah
Copy link
Collaborator Author

ydah commented Dec 11, 2023

If you want to add a commit to #289, you can close this PR and cherry-pick the revised commit 171e02c to #289 🙏

@yui-knk yui-knk mentioned this pull request Dec 12, 2023
Closed
@yui-knk yui-knk merged commit 5333a8d into ruby:master Dec 12, 2023
15 checks passed
@yui-knk
Copy link
Collaborator

yui-knk commented Dec 12, 2023

LGTM, thank you!

@ydah ydah deleted the fix-bug branch December 12, 2023 03:08
@ydah
Copy link
Collaborator Author

ydah commented Dec 12, 2023

Sorry, I was not able to submit my reply. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yui-knk yui-knk yui-knk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ydah @yui-knk