New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Actions mswin, update CI #319
Conversation
.github/workflows/ubuntu-macos.yml
Outdated
- name: load ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{matrix.ruby}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably harmless, but it's typically written as ruby-version: ${{ matrix.ruby }}
as below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in all workflows...
@MSP-Greg I can reproduce the issue in https://github.com/eregon/openssl/runs/433892746 |
There is no |
ruby master simply has no Confirmed when installed locally as well. |
2015 is too old, it must be a more recent change which forgets to copy the rake executable under |
```
$ gem list
*** LOCAL GEMS *** benchmark (default: 0.1.0)
|
Probably |
I'm trying to look at one msg and then 'bing', another one. Sorry. Are the files in the gems folder? No problem on Windows, and no specific code for the bundled gems. But, since Windows also has the cmd/bat binstubs, the code is different... |
Good old issue, short answer is I need to I'll trigger a build with that. |
Thanks everyone this looks great, let me know when I can merge it! |
I think the distinction is whether one builds from a tarball (even of the nightly or whatever it's called) or one builds from the repo... I recall some discussions in Ruby about the idea of whether testing should happen before or after Anyway, thanks for tracking down the issue. |
New ruby-head builds done, this time including rake and other bundled gems. @MSP-Greg Sorry, you were right, it was an issue with my ruby-head builds. |
Thanks to @eregon, the Ubuntu-macOS workflow should pass. The Windows mswin build is failing, but you've seen that in ruby/ruby. I assume it would be helpful to see that here. I don't believe there is a reasonable way to have an 'allow failure' on Actions. JFYI, ruby-loco is now building on Actions, three times a day, both mingw & mswin. The changes to the action (MSP-Greg/actions-ruby) to use mswin aren't really public, I'd like to get a few repos using it to see if mswin is okay... |
source $HOME/.rvm/scripts/rvm | ||
rake test TESTOPTS="-v --no-show-detail-immediately" OSSL_MDEBUG=1 | ||
env: | ||
CI: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To help with the issue that ruby/ruby runs Windows mswin CI, this PR adds that.
On the three Actions platforms, Ruby 2.3 thru master/head is testing on all, with Windows testing both mingw & mswin master/head builds.
I can delete the unused CI files, I thought saving them might helpful in the future for specialized CI use...
Lastly, mswin is failing (as it is in ruby/ruby) and Ubuntu master is failing with a permissions failure that I've opened an issue in ruby/setup-ruby in...