Gemify rake #862
Closed
Gemify rake #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve of this change. |
Some test expects some gems to be available on $LOAD_PATH. For example, RubyGem's test suite requires Rake. This is currently rather naive implementation, since we don't have RubyGems at hand to use something like Gem::Specification#add_self_to_load_path.
|
Now I noticed that some RubyGems were failing due to missing Rake, so the 7d2b6a8 commit add bundled gems on $LOAD_PATH (although the approach is rather naive ATM, but it can be improved later if needed). |
|
Weird, why it fails on travis? The gems are not expanded there for some reason? |
|
@voxik Travis instance is fragile environment :( |
mmasaki
pushed a commit
to mmasaki/ruby
that referenced
this pull request
May 30, 2015
* test/rake/*: ditto. * tool/rbinstall.rb: ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.