-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Check compiler warnings. #631
Conversation
9c38310
to
a70118c
Compare
a70118c
to
dbb0420
Compare
This already revealed problems that currently exist in master. From your comment at #615 (comment):
C99 syntax was not allowed before Ruby 2.7. Since Ruby 2.6 is EOL now, I think we can drop support for Ruby 2.6 in the master branch. (The code generating this warning is in master only.)
This needs to be fixed. |
Can you rebase this on top of the current master? I believe all warnings have been fixed now. |
dbb0420
to
9f8b2ac
Compare
Yes! Thanks for your great work fixing all the warnings! That's really great work! I am rebasing this PR now. Note I am trying to change the current syntax The syntax name is inspired from the |
9f8b2ac
to
9f538bb
Compare
9f538bb
to
2d6eeb1
Compare
I rebased the PR again with updating the commit message too. Below is the commit message. CI: Check compiler warnings. Add checks to make CI fail by compiler warnings in the If the I tested it on my forked repository. If the
|
You can see the https://github.com/ruby/openssl/actions/runs/5198494841/jobs/9374685609?pr=631#step:12:96 such as
|
Add checks to make CI fail by compiler warnings in the `rake compile`. If the `skip-warnings` (default: `false`, as an undefined variable is evaluated as `false` in the `if` syntax) is `true` in specific matrix cases, the cases skip the checks. If you want to skip new compiler warnings coming from external changes such as upgraded compiler or OpenSSL versions in the specific matrix cases, you can set the `skip-warnings: true` for the cases.
2d6eeb1
to
52402f6
Compare
This seems perfectly sensible to me! All 40 checks passed without warnings. Let's merge this. |
Let's try it. Thanks for reviewing the PR and checking the CI results! |
This PR fixes #626.
Add checks to make CI fail by compiler warnings in the
rake compile
.If the
skip-warnings
(default:false
, as an undefined variable is evaluated asfalse
in theif
syntax) istrue
in specific matrix cases, the cases skip the checks. If you want to skip new compiler warnings coming from external changes such as upgraded compiler or OpenSSL versions in the specific matrix cases, you can set theskip-warnings: true
for the cases.Note that this issue #628 was detected in the process of this work.