fix static symbol resolution #1069

flavorjones · 2023-06-24T18:35:36Z

This PR introduces separate object files (and build directories) for the dll (librubyparser.so) and the static archive (librubyparser.a) to ensure the dll makes public symbols public and the static archive does not.

I've also made the Makefile much quieter by default, but provide support for a V=1 argument for verbose mode (just like mkmf Makefiles).

This makes the difference between (uppercase T):

$ nm lib/yarp.so | fgrep yp_parse
0000000000031210 T yp_parse
0000000000003e1d t yp_parse.cold
00000000000313d0 T yp_parse_serialize
0000000000031160 T yp_parser_free
0000000000030ee0 T yp_parser_init
0000000000015520 t yp_parser_local_depth.isra.0
0000000000015450 t yp_parser_parameter_name_check
0000000000031140 T yp_parser_register_encoding_changed_callback
0000000000031150 T yp_parser_register_encoding_decode_callback

and (lowercase t):

$ nm lib/yarp.so | fgrep yp_parse
0000000000031050 t yp_parse
00000000000310d0 t yp_parse_serialize
0000000000030fa0 t yp_parser_free
0000000000030d20 t yp_parser_init
0000000000015200 t yp_parser_local_depth.isra.0
0000000000015130 t yp_parser_parameter_name_check
0000000000030f80 t yp_parser_register_encoding_changed_callback
0000000000030f90 t yp_parser_register_encoding_decode_callback

This is a prefactor so we can compile shared and static objects separately in a subsequent commit.

Closes ruby#1067

but also offer a V=1 option for verbose mode

kddnewton

Thank you!

This reverses the convention introduced in ruby#1069, and requires `YP_EXPORT_SYMBOLS` to be defined at compile-time when building a shared library. See related ruby#1111 which describes a symbol leakage problem in Ruby 3.3 (ruby head) that this commit, once merged upstream into Ruby, should address. Note that the tests introduced in a previous commit ensure that the static archive and shared objects are all being created correctly after this change.

This reverses the convention introduced in ruby#1069, and requires `YP_EXPORT_SYMBOLS` to be defined at compile-time when building a shared library. See related ruby#1111 which describes a symbol leakage problem in Ruby 3.3 (ruby head) that this commit, once merged upstream into Ruby, should address. Note that the tests introduced in a previous commit ensure that the static archive and shared objects are all being created correctly after this change. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>

flavorjones added 3 commits June 24, 2023 14:05

Move librubyparser objects into a build directory

972aa09

This is a prefactor so we can compile shared and static objects separately in a subsequent commit.

Ensure the C extension will resolve to librubyparser.a symbols

38527b0

Closes ruby#1067

Improve Makefile output to be quieter

cf22a79

but also offer a V=1 option for verbose mode

flavorjones mentioned this pull request Jun 24, 2023

Incorrect symbol resolution #1067

Closed

kddnewton approved these changes Jun 24, 2023

View reviewed changes

kddnewton merged commit f59c375 into ruby:main Jun 24, 2023
11 checks passed

flavorjones deleted the 1067-flavorjones-fix-static-symbol-resolution branch June 25, 2023 02:25

This was referenced Jul 1, 2023

Package up YARP as a gem #1110

Merged

Define YP_EXPORTED_FUNCTION as empty #1111

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix static symbol resolution #1069

fix static symbol resolution #1069

flavorjones commented Jun 24, 2023 •

edited

Loading

kddnewton left a comment

fix static symbol resolution #1069

fix static symbol resolution #1069

Conversation

flavorjones commented Jun 24, 2023 • edited Loading

kddnewton left a comment

Choose a reason for hiding this comment

flavorjones commented Jun 24, 2023 •

edited

Loading