Add data_loc method to Rust bindings
#2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which returns a location of the __END__ content.
kddnewton
requested changes
Jun 1, 2024
rust/ruby-prism/src/lib.rs
Outdated
| pub fn data_loc(&self) -> Option<Location<'_>> { | ||
| let root = self.source.as_ptr(); | ||
| let location = unsafe { &(*self.parser.as_ptr()).data_loc }; | ||
| if location.start >= root { |
There was a problem hiding this comment.
In other optional locations we're checking start.is_null() instead, can you do that here?
There was a problem hiding this comment.
Thank you, I changed the implementation to use is_null() .
be34f68
kddnewton
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2621
Currently Prism recognizes the
__END__content and provides a way to access it in Ruby, C, and Java APIs, but Rust bindings does not have it. This PR adds thedata_locmethod to Rust API.