Skip to content

Commit

Permalink
Get rid of anonymous eval calls
Browse files Browse the repository at this point in the history
Things declared in anonymous eval are always annoying to locate.
(profilers, etc)
  • Loading branch information
byroot committed Jan 11, 2023
1 parent 380bd78 commit f304205
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions lib/racc/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -260,11 +260,11 @@ def _racc_init_sysvars
# def next_token
# @q.shift
# end
class_eval %{
class_eval <<~RUBY, __FILE__, __LINE__ + 1
def do_parse
#{Racc_Main_Parsing_Routine}(_racc_setup(), false)
end
}
RUBY

# The method to fetch next token.
# If you use #do_parse method, you must implement #next_token.
Expand Down Expand Up @@ -322,11 +322,11 @@ def _racc_do_parse_rb(arg, in_debug)
#
# RECEIVER#METHOD_ID is a method to get next token.
# It must 'yield' the token, which format is [TOKEN-SYMBOL, VALUE].
class_eval %{
class_eval <<~RUBY, __FILE__, __LINE__ + 1
def yyparse(recv, mid)
#{Racc_YY_Parse_Method}(recv, mid, _racc_setup(), false)
end
}
RUBY

def _racc_yyparse_rb(recv, mid, arg, c_debug)
action_table, action_check, action_default, action_pointer,
Expand Down
4 changes: 2 additions & 2 deletions test/assets/cast.y
Original file line number Diff line number Diff line change
Expand Up @@ -636,14 +636,14 @@ restrict return short signed sizeof static struct switch typedef union
def self.feature(name)
attr_writer "#{name}_enabled"
class_eval <<-EOS
class_eval <<~RUBY, __FILE__, __LINE__ + 1
def enable_#{name}
@#{name}_enabled = true
end
def #{name}_enabled?
@#{name}_enabled
end
EOS
RUBY
end
private_class_method :feature
Expand Down
4 changes: 2 additions & 2 deletions test/regress/cast
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ restrict return short signed sizeof static struct switch typedef union

def self.feature(name)
attr_writer "#{name}_enabled"
class_eval <<-EOS
class_eval <<~RUBY, __FILE__, __LINE__ + 1
def enable_#{name}
@#{name}_enabled = true
end
def #{name}_enabled?
@#{name}_enabled
end
EOS
RUBY
end
private_class_method :feature

Expand Down

0 comments on commit f304205

Please sign in to comment.