Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyword args #326

Merged
merged 2 commits into from Sep 2, 2019
Merged

Update keyword args #326

merged 2 commits into from Sep 2, 2019

Conversation

@nobu
Copy link
Member

@nobu nobu commented Sep 1, 2019

Follows recent changes on keyword arguments in ruby 2.7.

nobu added 2 commits Aug 31, 2019
@hsbt hsbt merged commit 0780c70 into ruby:master Sep 2, 2019
1 check failed
1 check failed
codeclimate 2 issues to fix
Details
yahonda added a commit to yahonda/google-cloud-ruby that referenced this pull request Mar 3, 2020
Related to googleapis#4884

To prepare Ruby 3 keyword arguments support, there are some other gems also need update. `rake` is one of them.

* Rake 13.0.0 supports Ruby 3 keyword arguments by ruby/rake#326
* Rake 13 drops Ruby 2.1 or older support by ruby/rake#325
* Gems under `google-cloud-ruby` repository only supports Ruby 2.4 or higher then dropping Ruby 2.1 support should not be an issue.

I have bumped all of Rake under `google-cloud-ruby` repository.
quartzmo added a commit to googleapis/google-cloud-ruby that referenced this pull request Mar 4, 2020
To prepare Ruby 3 keyword arguments support, there are some other gems also need update. `rake` is one of them.

* Rake 13.0.0 supports Ruby 3 keyword arguments by ruby/rake#326
* Rake 13 drops Ruby 2.1 or older support by ruby/rake#325
* Gems under `google-cloud-ruby` repository only supports Ruby 2.4 or higher then dropping Ruby 2.1 support should not be an issue.

refs: #4884
pr: #4897
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants