New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chained extensions #39

Merged
merged 4 commits into from Apr 18, 2017

Conversation

3 participants
@pjump

pjump commented Apr 11, 2015

rules such as

rule ".min.js" => ".js" do |t|
end

didn't work because Rake would simple replace the js part of".min.js" with ".js", creating a cyclic dependency. This PR makes rules like this work by always making sure the whole target pattern of is replaced, rather than just the very final extension.

All tests green. A test for the new feature added.

@pjump

This comment has been minimized.

pjump commented Apr 11, 2015

On a somewhat unrelated topic, does anyone know how to gemify this repo so I can install it?

@pjump

This comment has been minimized.

pjump commented Jun 3, 2015

Any opinion on this?

@hsbt

This comment has been minimized.

Member

hsbt commented Jan 6, 2017

@pjump Sorry to my late response. I agreed to merge your proposal.

@hsbt hsbt self-requested a review Jan 6, 2017

@@ -10,6 +10,7 @@ class TestRakeRules < Rake::TestCase
OBJFILE = "abc.o"
FOOFILE = "foo"
DOTFOOFILE = ".foo"
MINFILE = 'abc.min.o'

This comment has been minimized.

@hsbt

hsbt Jan 6, 2017

Member

Can you align = indentation?

@hsbt

hsbt approved these changes Apr 18, 2017

@hsbt hsbt merged commit 252ad9e into ruby:master Apr 18, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

unasuke added a commit to unasuke/mail that referenced this pull request Apr 12, 2018

Set full path of the ragel source file to rule of a rake rule source
In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task "ragel:generate" is works incorrectry that require
wrong ragel source file.
As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb"
needs "lib/mail/parsers/address_lists.rl", but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.

unasuke added a commit to unasuke/mail that referenced this pull request Apr 12, 2018

Set full path of the ragel source file to rake task
In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task "ragel:generate" is works incorrectry that require
wrong ragel source file.
As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb"
needs "lib/mail/parsers/address_lists.rl", but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.

jeremy added a commit to mikel/mail that referenced this pull request Apr 13, 2018

Set full path of the ragel source file to rake task
In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task "ragel:generate" is works incorrectry that require
wrong ragel source file.
As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb"
needs "lib/mail/parsers/address_lists.rl", but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment