Chained extensions #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a somewhat unrelated topic, does anyone know how to gemify this repo so I can install it? |
|
Any opinion on this? |
|
@pjump Sorry to my late response. I agreed to merge your proposal. |
hsbt
requested changes
Jan 6, 2017
test/test_rake_rules.rb
Outdated
| @@ -10,6 +10,7 @@ class TestRakeRules < Rake::TestCase | |||
| OBJFILE = "abc.o" | |||
| FOOFILE = "foo" | |||
| DOTFOOFILE = ".foo" | |||
| MINFILE = 'abc.min.o' | |||
hsbt
approved these changes
Apr 18, 2017
unasuke
added a commit
to unasuke/mail
that referenced
this pull request
Apr 12, 2018
In Rake v12.1.0 or higher, the algorithm of resolve file dependency was changed in ruby/rake#39 . Then rake task "ragel:generate" is works incorrectry that require wrong ragel source file. As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb" needs "lib/mail/parsers/address_lists.rl", but this file is not exist. Therefore, fixed that to pass full path of the ragel source file to rule.
unasuke
added a commit
to unasuke/mail
that referenced
this pull request
Apr 12, 2018
In Rake v12.1.0 or higher, the algorithm of resolve file dependency was changed in ruby/rake#39 . Then rake task "ragel:generate" is works incorrectry that require wrong ragel source file. As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb" needs "lib/mail/parsers/address_lists.rl", but this file is not exist. Therefore, fixed that to pass full path of the ragel source file to rule.
jeremy
pushed a commit
to mikel/mail
that referenced
this pull request
Apr 13, 2018
In Rake v12.1.0 or higher, the algorithm of resolve file dependency was changed in ruby/rake#39 . Then rake task "ragel:generate" is works incorrectry that require wrong ragel source file. As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb" needs "lib/mail/parsers/address_lists.rl", but this file is not exist. Therefore, fixed that to pass full path of the ragel source file to rule.
composerinteralia
added a commit
to composerinteralia/mail
that referenced
this pull request
Mar 10, 2021
Currently the ragel:svg task is broken. We need to use the full path because of a change to Rake in ruby/rake#39. We already changed this for the ragel:generate task in mikel@20ffe29
jeremy
pushed a commit
to mikel/mail
that referenced
this pull request
Mar 11, 2021
Currently the ragel:svg task is broken. We need to use the full path because of a change to Rake in ruby/rake#39. We already changed this for the ragel:generate task in 20ffe29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules such as
didn't work because Rake would simple replace the js part of".min.js" with ".js", creating a cyclic dependency. This PR makes rules like this work by always making sure the whole target pattern of is replaced, rather than just the very final extension.
All tests green. A test for the new feature added.