Set full path of the ragel source file to rake task by unasuke · Pull Request #1221 · mikel/mail

unasuke · 2018-04-12T15:39:41Z

In Rake v12.1.0 or higher, the algorithm of resolve file dependency
was changed in ruby/rake#39 .

Then rake task ragel:generate is works incorrectry that require
wrong ragel source file.
As the example, rake resolves lib/mail/parsers/address_lists_parser.rb
needs lib/mail/parsers/address_lists.rl, but this file is not exist.

Therefore, fixed that to pass full path of the ragel source file
to rule.

rake v12.0.0

$ bundle exec rake --version
rake, version 12.0.0

$ bundle exec rake ragel:generate --rules
Attempting Rule lib/mail/parsers/address_lists_parser.rb => lib/mail/parsers/address_lists_parser.rl
(lib/mail/parsers/address_lists_parser.rb => lib/mail/parsers/address_lists_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_disposition_parser.rb => lib/mail/parsers/content_disposition_parser.rl
(lib/mail/parsers/content_disposition_parser.rb => lib/mail/parsers/content_disposition_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_location_parser.rb => lib/mail/parsers/content_location_parser.rl
(lib/mail/parsers/content_location_parser.rb => lib/mail/parsers/content_location_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_transfer_encoding_parser.rb => lib/mail/parsers/content_transfer_encoding_parser.rl
(lib/mail/parsers/content_transfer_encoding_parser.rb => lib/mail/parsers/content_transfer_encoding_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_type_parser.rb => lib/mail/parsers/content_type_parser.rl
(lib/mail/parsers/content_type_parser.rb => lib/mail/parsers/content_type_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/date_time_parser.rb => lib/mail/parsers/date_time_parser.rl
(lib/mail/parsers/date_time_parser.rb => lib/mail/parsers/date_time_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/envelope_from_parser.rb => lib/mail/parsers/envelope_from_parser.rl
(lib/mail/parsers/envelope_from_parser.rb => lib/mail/parsers/envelope_from_parser.rl ... EXIST)
# snip..
Attempting Rule lib/mail/parsers/received_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/received_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)

rake v12.1.0 (without this change)

$ bundle exec rake --version
rake, version 12.1.0

$ bundle exec rake ragel:generate --rules
Attempting Rule lib/mail/parsers/address_lists_parser.rb => lib/mail/parsers/address_lists.rl
(lib/mail/parsers/address_lists_parser.rb => lib/mail/parsers/address_lists.rl ... FAIL)
Attempting Rule lib/mail/parsers/content_disposition_parser.rb => lib/mail/parsers/content_disposition.rl
(lib/mail/parsers/content_disposition_parser.rb => lib/mail/parsers/content_disposition.rl ... FAIL)
Attempting Rule lib/mail/parsers/content_location_parser.rb => lib/mail/parsers/content_location.rl
(lib/mail/parsers/content_location_parser.rb => lib/mail/parsers/content_location.rl ... FAIL)
Attempting Rule lib/mail/parsers/content_transfer_encoding_parser.rb => lib/mail/parsers/content_transfer_encoding.rl
(lib/mail/parsers/content_transfer_encoding_parser.rb => lib/mail/parsers/content_transfer_encoding.rl ... FAIL)
Attempting Rule lib/mail/parsers/content_type_parser.rb => lib/mail/parsers/content_type.rl
(lib/mail/parsers/content_type_parser.rb => lib/mail/parsers/content_type.rl ... FAIL)
Attempting Rule lib/mail/parsers/date_time_parser.rb => lib/mail/parsers/date_time.rl
(lib/mail/parsers/date_time_parser.rb => lib/mail/parsers/date_time.rl ... FAIL)
Attempting Rule lib/mail/parsers/envelope_from_parser.rb => lib/mail/parsers/envelope_from.rl
(lib/mail/parsers/envelope_from_parser.rb => lib/mail/parsers/envelope_from.rl ... FAIL)
Attempting Rule lib/mail/parsers/message_ids_parser.rb => lib/mail/parsers/message_ids.rl
(lib/mail/parsers/message_ids_parser.rb => lib/mail/parsers/message_ids.rl ... FAIL)
Attempting Rule lib/mail/parsers/mime_version_parser.rb => lib/mail/parsers/mime_version.rl
(lib/mail/parsers/mime_version_parser.rb => lib/mail/parsers/mime_version.rl ... FAIL)
Attempting Rule lib/mail/parsers/phrase_lists_parser.rb => lib/mail/parsers/phrase_lists.rl
(lib/mail/parsers/phrase_lists_parser.rb => lib/mail/parsers/phrase_lists.rl ... FAIL)
Attempting Rule lib/mail/parsers/received_parser.rb => lib/mail/parsers/received.rl
(lib/mail/parsers/received_parser.rb => lib/mail/parsers/received.rl ... FAIL)

rake v12.1.0 (with this change)

$ bundle exec rake --version
rake, version 12.1.0

$ bundle exec rake ragel:generate --rules
Attempting Rule lib/mail/parsers/address_lists_parser.rb => lib/mail/parsers/address_lists_parser.rl
(lib/mail/parsers/address_lists_parser.rb => lib/mail/parsers/address_lists_parser.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_disposition_parser.rb => lib/mail/parsers/content_disposition_parser.rl
(lib/mail/parsers/content_disposition_parser.rb => lib/mail/parsers/content_disposition_parser.rl ... EXIST)
# snip..
Attempting Rule lib/mail/parsers/content_disposition_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_disposition_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
ragel -s -R -L -F1 -o lib/mail/parsers/content_disposition_parser.rb lib/mail/parsers/content_disposition_parser.rl
fsm name  : content_disposition
num states: 47

Attempting Rule lib/mail/parsers/content_location_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_location_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_location_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_location_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
ragel -s -R -L -F1 -o lib/mail/parsers/content_location_parser.rb lib/mail/parsers/content_location_parser.rl
fsm name  : content_location
num states: 41

Attempting Rule lib/mail/parsers/content_transfer_encoding_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_transfer_encoding_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_transfer_encoding_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_transfer_encoding_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
ragel -s -R -L -F1 -o lib/mail/parsers/content_transfer_encoding_parser.rb lib/mail/parsers/content_transfer_encoding_parser.rl
fsm name  : content_transfer_encoding
num states: 27

Attempting Rule lib/mail/parsers/content_type_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_type_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
Attempting Rule lib/mail/parsers/content_type_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/content_type_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
ragel -s -R -L -F1 -o lib/mail/parsers/content_type_parser.rb lib/mail/parsers/content_type_parser.rl
fsm name  : content_type
num states: 55

# snip..

Attempting Rule lib/mail/parsers/phrase_lists_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/phrase_lists_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
Attempting Rule lib/mail/parsers/phrase_lists_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/phrase_lists_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
ragel -s -R -L -F1 -o lib/mail/parsers/phrase_lists_parser.rb lib/mail/parsers/phrase_lists_parser.rl
fsm name  : date_time
num states: 46

Attempting Rule lib/mail/parsers/received_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/received_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
Attempting Rule lib/mail/parsers/received_parser.rl => lib/mail/parsers/rfc5322.rl
(lib/mail/parsers/received_parser.rl => lib/mail/parsers/rfc5322.rl ... EXIST)
ragel -s -R -L -F1 -o lib/mail/parsers/received_parser.rb lib/mail/parsers/received_parser.rl
fsm name  : date_time
num states: 655

In Rake v12.1.0 or higher, the algorithm of resolve file dependency was changed in ruby/rake#39 . Then rake task "ragel:generate" is works incorrectry that require wrong ragel source file. As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb" needs "lib/mail/parsers/address_lists.rl", but this file is not exist. Therefore, fixed that to pass full path of the ragel source file to rule.

yahonda · 2018-04-12T16:47:54Z

Great work.

I recall this CI error which was reported at sunspot/sunspot#889
which can be addressed by yahonda@c648205

bundle exec rake
bundler: failed to load command: rake (/home/travis/build/mikel/mail/vendor/bundle/ruby/2.5.0/bin/rake)
LoadError: cannot load such file -- bundler/dep_proxy

I hope it makes CI green.

file -- bundler/dep_proxy` ```ruby bundle exec rake bundler: failed to load command: rake (/home/travis/build/mikel/mail/vendor/bundle/ruby/2.5.0/bin/rake) LoadError: cannot load such file -- bundler/dep_proxy ```

unasuke mentioned this pull request Apr 12, 2018

Reduce warnings "mismatched indentations" on ruby 2.6 #1222

Closed

yahonda mentioned this pull request Apr 12, 2018

Address LoadError: cannot load such file -- bundler/dep_proxy #1223

Closed

Perform gem install bundler to address `LoadError: cannot load such

8079b4a

file -- bundler/dep_proxy` ```ruby bundle exec rake bundler: failed to load command: rake (/home/travis/build/mikel/mail/vendor/bundle/ruby/2.5.0/bin/rake) LoadError: cannot load such file -- bundler/dep_proxy ```

jeremy approved these changes Apr 13, 2018

View reviewed changes

jeremy merged commit 3668ee8 into mikel:master Apr 13, 2018

unasuke deleted the rake_task_ragel_generate branch April 13, 2018 07:18

koic mentioned this pull request May 2, 2018

Add more Ruby versions on CI toshimaru/rubocop-rails#29

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set full path of the ragel source file to rake task#1221

Set full path of the ragel source file to rake task#1221
jeremy merged 2 commits into
mikel:masterfrom
unasuke:rake_task_ragel_generate

unasuke commented Apr 12, 2018 •

edited

Loading

Uh oh!

yahonda commented Apr 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

unasuke commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rake v12.0.0

rake v12.1.0 (without this change)

rake v12.1.0 (with this change)

Uh oh!

yahonda commented Apr 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

unasuke commented Apr 12, 2018 •

edited

Loading