New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib: the headers keyword for CSV.foreach can take String #1864

Open

tk0miya wants to merge 1 commit into ruby:master from tk0miya:csv

+14 −2

Contributor

tk0miya commented Jun 5, 2024

The headers keyword option of CSV.foreach can take String, Symbol and Array too. Therefore, this adds them to the type definition.

refs:

Note:

In https://github.com/ruby/rbs/pull/1738/files#r1468802569, @m11o was aware of the lackness of the types, but they determined to support only "true" value at first.


          stdlib: the headers keyword for CSV.foreach can take String

7d13d80

The headers keyword option of `CSV.foreach` can take String, Symbol and
Array too.  Therefore, this adds them to the type definition.

refs:
* https://docs.ruby-lang.org/en/3.3/CSV.html#method-c-foreach
* https://docs.ruby-lang.org/en/3.3/CSV.html#class-CSV-label-Options+for+Parsing

Note:

In https://github.com/ruby/rbs/pull/1738/files#r1468802569, @m11o
was aware of the lackness of the types, but they determined to support
only "true" value at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet