Add test and update types for Kernel #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
commented
Nov 11, 2019
| def to_s: () -> String | ||
|
|
||
| def trust: () -> self | ||
|
|
||
| def `undef`: (*untyped arg) -> void |
There was a problem hiding this comment.
Ruby does not have undef method.
pocke
commented
Nov 11, 2019
| def Array: (NilClass x) -> untyped | ||
| | (untyped x) -> ::Array[untyped] | ||
|
|
||
| def BigDecimal: (Integer | Float | Rational | BigDecimal | String initial, ?Integer digits, ?exception: bool exception) -> BigDecimal |
There was a problem hiding this comment.
BigDecimal is a standard library. So it should be defined as an extension.
pocke
changed the title
soutaro
reviewed
Nov 13, 2019
| | (?Class arg0, ?::Array[String] arg1) -> bot | ||
| | (?Class arg0, ?String arg1, ?::Array[String] arg2) -> bot | ||
| | (String arg0) -> bot | ||
| | (?Exception arg0, ?String arg1, ?::Array[String] arg2) -> bot |
There was a problem hiding this comment.
I think the type of fail should be updated later, but not clear enough how it can be now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for all methods for
Kernelmodule. And it updates some types because they are wrong.I gave up writing tests for some methods, because they are difficult.
But
test_*methods are available for all methods. I put "TODO" comment to the methods I gave up.