Fix bundler related test for test-bundled-gems #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
reviewed
Sep 5, 2021
| command_line = if defined?(Bundler) | ||
| [ruby, "-rbundler/setup", "-rrbs/test/setup", "sample.rb"] | ||
| else | ||
| command_line = if ENV['RUBY'] |
There was a problem hiding this comment.
Seems like we can omit the ruby var, but it's up to you. (If you have another fix...)
There was a problem hiding this comment.
Thanks, I removed the ruby var. 🚮
soutaro
reviewed
Sep 5, 2021
| @@ -333,6 +333,7 @@ def test_collection_install | |||
|
|
|||
| path: #{dir.join('gem_rbs_collection')} | |||
| YAML | |||
| dir.join('Gemfile').write('') | |||
pocke
force-pushed
the
Fix_bundler_related_test_for_test_bundled_gems
branch
from
c79a4e7
to
1bf2784
Compare
pocke
force-pushed
the
Fix_bundler_related_test_for_test_bundled_gems
branch
from
1bf2784
to
5cebaf8
Compare
pocke
added a commit
to soutaro/ruby
that referenced
this pull request
Sep 5, 2021
soutaro
added a commit
to ruby/ruby
that referenced
this pull request
Sep 5, 2021
* Bundle RBS 1.6.0 * Specify bundled rbs commit hash to fix test ref ruby/rbs#778 * Bundle RBS 1.6.1 Co-authored-by: Masataka Pocke Kuwabara <kuwabara@pocke.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bundler related tests fro test-bundled-gems.
The RBS's tests fail on ruby/ruby's CI. https://github.com/ruby/ruby/pull/4809/checks?check_run_id=3516979076
The following three tests fail
require 'bundler'always, soif defined?(Bundler)is not appropriate solution to detect availability ofbunder/setup.Bundler::LockfileParserneedsGemfilein the current directory to detectBundler.root, but the CLI test doesn't putGemfile.BUNDLE_GEMFILEenv var.bundle installas a dependency of goodcheck gem.rbs-amber.